Open
Conversation
Owner
|
Thanks for submitting this. I'll take a closer look at it this weekend. |
Owner
|
I've been thinking for a while that the time series functionality would be better suited as part of the existing gateways instead of in separate gateways. For example, instead of Something like this: $activities = $factory->getActivityGateway();
$activities->getTimeSeries('distance', 'today', '7d');
public function getTimeSeries($type, $base_date = null, $end_date = null)
{
$url = '/activities/log/' . $type;
return $this->makeTimeSeriesApiRequest($url, $base_date, $end_date);
}What do you think? I'd also get rid of the magic methods, favoring explicitly defined methods like this instead: $activities->getMinutesVeryActive();
public function getMinutesVeryActive($base_date = null, $end_date = null)
{
return $this->getTimeSeries('minutesVeryActive', $base_date, $end_date);
}
public function getTrackerCalories($base_date = null, $end_date = null)
{
return $this->getTimeSeries('tracker/calories', $base_date, $end_date);
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I created a set of Time Series Gateways for your repo, take a look and let me know if u wanna merge.